fix(docs): revert npm hash-pinning that broke the Docs build#869
Closed
michalharakal wants to merge 1 commit into
Closed
fix(docs): revert npm hash-pinning that broke the Docs build#869michalharakal wants to merge 1 commit into
michalharakal wants to merge 1 commit into
Conversation
PR #848 pinned the Antora/mermaid npm deps via GitLab/GitHub `/-/tree/<hash>` URLs, but those are web-UI pages, not tarballs. npm downloaded HTML and failed every docs build with `TAR_BAD_ARCHIVE: Unrecognized archive format`, breaking the Docs job on all PRs since the merge. Restore the previous registry version pins (antora 3.1.x, lunr-extension 1.0.0-alpha.8, mermaid-cli 11, asciidoctor-kroki 0.18) until the commit-hash pinning approach is reworked. Verified: `docker build --no-cache` succeeds and `antora --version` reports 3.1.15. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
📖 Documentation Preview The documentation has been built successfully for this PR. Generated Files:
Artifacts:
This comment will be updated automatically when the PR is updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Since PR #848 (Pin npm packages with their commit hash, merged as
343f54a3), the Docs job has failed on every PR at the Build Antora image step.That PR rewrote the
npm installindocs/.docker/Dockerfileto pull deps from/-/tree/<hash>URLs:Those are GitLab/GitHub web-UI pages, not tarballs, so npm downloads HTML and fails with:
(Confirmed in run 30004869866.)
Fix
Restore the previous registry version pins until the commit-hash approach is reworked:
@antora/cli@3.1,@antora/site-generator@3.1@antora/lunr-extension@1.0.0-alpha.8@mermaid-js/mermaid-cli@11asciidoctor-kroki@0.18The
node:20-alpineimage digest pin and everything else from #848 are left untouched. A comment records the reverted hashes/target versions for whoever reworks the pinning.Verification
🤖 Generated with Claude Code